Linking Bigarray references #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rmeis06 its good practice to indicate on the issues prior to attempting it as sometimes other applicants have indicated prior interest in attempting it. |
|
Alright, sorry I don't know that I understood the instructions in #2141 under "Third step: a good first issue" as it asks only to open a PR, rather than requesting to be assigned an issue. |
christinerose
approved these changes
Mar 12, 2024
cuihtlauac
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should partially fix #2088
I found some references to Bigarray in the following files:
news/ocaml/ocaml-2022-02.md
releases/4.07.0.md
It didn't seem like I should update them because they're release notes and news, so I left them as is. But I can update them if that's desired.
@cuihtlauac @SaySayo How does this look?