Correctly invert text on "Is OCaml Web" page #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing dark:prose-invert tag - Move header and tagline inside the body. This also removes some padding, to make it more consistent with pages.
cuihtlauac
approved these changes
Mar 13, 2024
|
The same issue is there on the docs pages as well. For instance, look at the following example: Dark Mode
Light Mode
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Is OCaml Xyz Yet?" pages (currently only Is OCaml Web Yet?) are not correctly styled in dark mode, leading to hard to read text.
This commit adds the missing tag
dark:prose-invertclass to the page - a rudimentary search shows that this is the only page missing it. In order for the heading and tagline to also be styled, I've moved them inside the prose tag (followingtutorial.eml, which is used for most pages in the "Guides" section).This does slightly change the layout of the page (the header is slightly smaller), but this is more consistent with other pages in this section, so feels like a win. Happy to revert this if preferred though!