Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn exercise 023 to practice #2230

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Turn exercise 023 to practice #2230

merged 5 commits into from
Mar 27, 2024

Conversation

Ozyugoo
Copy link
Contributor

@Ozyugoo Ozyugoo commented Mar 17, 2024

No description provided.

@Ozyugoo
Copy link
Contributor Author

Ozyugoo commented Mar 17, 2024

Hi, @cuihtlauac kindly check if this is what you asked me to do.

practice/023/answer/impl.ml Outdated Show resolved Hide resolved
practice/023/ex.ml Outdated Show resolved Hide resolved
@cuihtlauac cuihtlauac added the outreachy Outreachy contributions and blog posts label Mar 25, 2024
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing :-(

practice/023/answer/impl.ml Outdated Show resolved Hide resolved
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dune test --root . answer is failing

@Ozyugoo
Copy link
Contributor Author

Ozyugoo commented Mar 27, 2024

Tests are failing :-(

Hey @cuihtlauac please look at this, kindly point me to the right direction

@Ozyugoo
Copy link
Contributor Author

Ozyugoo commented Mar 27, 2024

dune test --root . answer is failing

I know, but I don't exactly understand what am doing wrong.

@cuihtlauac
Copy link
Collaborator

dune test --root . answer is failing

I know, but I don't exactly understand what am doing wrong

One of the expected results in the test is wrong. Probably a typo.

@Ozyugoo
Copy link
Contributor Author

Ozyugoo commented Mar 27, 2024

dune test --root . answer is failing

I know, but I don't exactly understand what am doing wrong

One of the expected results in the test is wrong. Probably a typo.

Thank you @cuihtlauac I have seen it and it is good to go now

@cuihtlauac cuihtlauac merged commit 648a515 into ocaml:main Mar 27, 2024
3 checks passed
@Ozyugoo Ozyugoo deleted the 023 branch March 29, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Outreachy contributions and blog posts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants