Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /api/** redirection #2352

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Add /api/** redirection #2352

merged 2 commits into from
Apr 17, 2024

Conversation

mtelvers
Copy link
Contributor

Doing a Google search of ocaml map (for example) returns these two URLs as the top results:

With the current code base, both of these links are broken. I propose this PR as a quick fix.

Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

.ocamlformat Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be part of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perils of git commit -a. I removed the version = 0.25.1 to allow me to format the project with the current version of ocamlformat, which was the version that I had installed. Perhaps we should also upgrade the ocamlformat version requirement to 0.26.1?

@sabine sabine merged commit bf41736 into ocaml:main Apr 17, 2024
3 checks passed
@mtelvers mtelvers deleted the api-redirection branch April 17, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants