Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle lts, default and missing version in middleware #2358

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Conversation

cuihtlauac
Copy link
Collaborator

@cuihtlauac cuihtlauac commented Apr 17, 2024

Fix Issue #2357

New redirects also introduced

  • X into X.max
  • X.Y.Z into X.Y

@cuihtlauac cuihtlauac requested a review from sabine April 17, 2024 18:10
Cuihtlauac ALVARADO added 2 commits April 18, 2024 09:49
Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable overall. Just one point in the comment below.

src/ocamlorg_web/lib/middleware.ml Outdated Show resolved Hide resolved
@cuihtlauac cuihtlauac merged commit 43f58c4 into main Apr 19, 2024
3 checks passed
@cuihtlauac cuihtlauac deleted the fix-2357 branch April 19, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual pages without a version in the URL return an empty body and no redirect
2 participants