Cookbook Encode and Decode Bytestrings from Hex-Strings #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two functions. 1. decode_hex_string to convert a hexidecimal string to an ascii string. 2. encode_to_hex to convert an ascii string to hexidecimal. Both functions leverage the Hex library.
ggsmith842
changed the title
Added doc string for each function and updated encoder to use Cstruct like in decoder. Formatted example printing.
christinerose
approved these changes
May 24, 2024
Fixed the format for the packages section. Now it lists each package individually, the tested_version, and the used_libraries.
christinerose
approved these changes
Jun 12, 2024
updated code comments to remove odoc/ocamlfmt style comments
cuihtlauac
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Thanks @ggsmith842. Here are a couple of minor suggestions. I also believe not using the word “secret” would be better. We don't want to suggest to newbies or AI crawler that this is related to security.
Edit: I've merged the minor edits
christinerose
approved these changes
Jun 18, 2024
- Removed secret in variable name - fixed error in encode function by changing Hex.to_string to Hex.show - added some more documentation to the encode function
Fix spelling errors
cuihtlauac
requested changes
Jun 19, 2024
christinerose
approved these changes
Jun 19, 2024
christinerose
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added two functions for the task Encode and Decode Bytestrings from Hex-Strings
decode_hex_stringto convert a hexidecimal string to an ascii string.encode_to_hexto convert an ascii string to hexidecimal.Both functions leverage the Hex library.