Skip to content

Commit

Permalink
Move Location.absname to Clflags
Browse files Browse the repository at this point in the history
  • Loading branch information
Armaël Guéneau committed Jul 5, 2018
1 parent dda4ad6 commit e3f2c54
Show file tree
Hide file tree
Showing 11 changed files with 65 additions and 73 deletions.
116 changes: 56 additions & 60 deletions .depend
Expand Up @@ -233,13 +233,13 @@ typing/includecore.cmi : typing/types.cmi typing/typedtree.cmi \
parsing/location.cmi typing/ident.cmi typing/env.cmi
typing/includemod.cmo : typing/types.cmi typing/typedtree.cmi utils/tbl.cmi \
typing/subst.cmi typing/printtyp.cmi typing/primitive.cmi typing/path.cmi \
typing/mtype.cmi utils/misc.cmi parsing/location.cmi \
typing/oprint.cmi typing/mtype.cmi utils/misc.cmi parsing/location.cmi \
typing/includecore.cmi typing/includeclass.cmi typing/ident.cmi \
typing/env.cmi typing/ctype.cmi typing/cmt_format.cmi utils/clflags.cmi \
parsing/builtin_attributes.cmi typing/btype.cmi typing/includemod.cmi
typing/includemod.cmx : typing/types.cmx typing/typedtree.cmx utils/tbl.cmx \
typing/subst.cmx typing/printtyp.cmx typing/primitive.cmx typing/path.cmx \
typing/mtype.cmx utils/misc.cmx parsing/location.cmx \
typing/oprint.cmx typing/mtype.cmx utils/misc.cmx parsing/location.cmx \
typing/includecore.cmx typing/includeclass.cmx typing/ident.cmx \
typing/env.cmx typing/ctype.cmx typing/cmt_format.cmx utils/clflags.cmx \
parsing/builtin_attributes.cmx typing/btype.cmx typing/includemod.cmi
Expand Down Expand Up @@ -302,23 +302,23 @@ typing/printpat.cmo : typing/types.cmi typing/typedtree.cmi typing/ident.cmi \
typing/printpat.cmx : typing/types.cmx typing/typedtree.cmx typing/ident.cmx \
parsing/asttypes.cmi typing/printpat.cmi
typing/printpat.cmi : typing/typedtree.cmi parsing/asttypes.cmi
typing/printtyp.cmo : typing/types.cmi typing/primitive.cmi \
typing/predef.cmi typing/path.cmi parsing/parsetree.cmi \
typing/outcometree.cmi typing/oprint.cmi utils/misc.cmi \
parsing/longident.cmi parsing/location.cmi typing/ident.cmi \
typing/env.cmi typing/ctype.cmi utils/clflags.cmi \
typing/printtyp.cmo : utils/warnings.cmi typing/types.cmi \
typing/primitive.cmi typing/predef.cmi typing/path.cmi \
parsing/parsetree.cmi typing/outcometree.cmi typing/oprint.cmi \
utils/misc.cmi parsing/longident.cmi parsing/location.cmi \
typing/ident.cmi typing/env.cmi typing/ctype.cmi utils/clflags.cmi \
parsing/builtin_attributes.cmi typing/btype.cmi parsing/asttypes.cmi \
typing/printtyp.cmi
typing/printtyp.cmx : typing/types.cmx typing/primitive.cmx \
typing/predef.cmx typing/path.cmx parsing/parsetree.cmi \
typing/outcometree.cmi typing/oprint.cmx utils/misc.cmx \
parsing/longident.cmx parsing/location.cmx typing/ident.cmx \
typing/env.cmx typing/ctype.cmx utils/clflags.cmx \
typing/printtyp.cmx : utils/warnings.cmx typing/types.cmx \
typing/primitive.cmx typing/predef.cmx typing/path.cmx \
parsing/parsetree.cmi typing/outcometree.cmi typing/oprint.cmx \
utils/misc.cmx parsing/longident.cmx parsing/location.cmx \
typing/ident.cmx typing/env.cmx typing/ctype.cmx utils/clflags.cmx \
parsing/builtin_attributes.cmx typing/btype.cmx parsing/asttypes.cmi \
typing/printtyp.cmi
typing/printtyp.cmi : typing/types.cmi typing/path.cmi \
typing/outcometree.cmi parsing/longident.cmi typing/ident.cmi \
typing/env.cmi parsing/asttypes.cmi
typing/outcometree.cmi parsing/longident.cmi parsing/location.cmi \
typing/ident.cmi typing/env.cmi parsing/asttypes.cmi
typing/printtyped.cmo : typing/types.cmi typing/typedtree.cmi \
parsing/printast.cmi typing/path.cmi utils/misc.cmi parsing/longident.cmi \
parsing/location.cmi typing/ident.cmi parsing/asttypes.cmi \
Expand Down Expand Up @@ -363,20 +363,20 @@ typing/typeclass.cmo : utils/warnings.cmi typing/typetexp.cmi \
typing/types.cmi typing/typedtree.cmi typing/typedecl.cmi \
typing/typecore.cmi typing/subst.cmi typing/stypes.cmi \
typing/printtyp.cmi typing/predef.cmi typing/path.cmi \
parsing/parsetree.cmi utils/misc.cmi parsing/longident.cmi \
parsing/location.cmi typing/includeclass.cmi typing/ident.cmi \
typing/env.cmi typing/ctype.cmi typing/cmt_format.cmi utils/clflags.cmi \
parsing/builtin_attributes.cmi typing/btype.cmi parsing/asttypes.cmi \
parsing/ast_helper.cmi typing/typeclass.cmi
parsing/parsetree.cmi typing/oprint.cmi utils/misc.cmi \
parsing/longident.cmi parsing/location.cmi typing/includeclass.cmi \
typing/ident.cmi typing/env.cmi typing/ctype.cmi typing/cmt_format.cmi \
utils/clflags.cmi parsing/builtin_attributes.cmi typing/btype.cmi \
parsing/asttypes.cmi parsing/ast_helper.cmi typing/typeclass.cmi
typing/typeclass.cmx : utils/warnings.cmx typing/typetexp.cmx \
typing/types.cmx typing/typedtree.cmx typing/typedecl.cmx \
typing/typecore.cmx typing/subst.cmx typing/stypes.cmx \
typing/printtyp.cmx typing/predef.cmx typing/path.cmx \
parsing/parsetree.cmi utils/misc.cmx parsing/longident.cmx \
parsing/location.cmx typing/includeclass.cmx typing/ident.cmx \
typing/env.cmx typing/ctype.cmx typing/cmt_format.cmx utils/clflags.cmx \
parsing/builtin_attributes.cmx typing/btype.cmx parsing/asttypes.cmi \
parsing/ast_helper.cmx typing/typeclass.cmi
parsing/parsetree.cmi typing/oprint.cmx utils/misc.cmx \
parsing/longident.cmx parsing/location.cmx typing/includeclass.cmx \
typing/ident.cmx typing/env.cmx typing/ctype.cmx typing/cmt_format.cmx \
utils/clflags.cmx parsing/builtin_attributes.cmx typing/btype.cmx \
parsing/asttypes.cmi parsing/ast_helper.cmx typing/typeclass.cmi
typing/typeclass.cmi : typing/types.cmi typing/typedtree.cmi \
parsing/parsetree.cmi parsing/longident.cmi parsing/location.cmi \
typing/ident.cmi typing/env.cmi typing/ctype.cmi parsing/asttypes.cmi
Expand Down Expand Up @@ -406,7 +406,7 @@ typing/typecore.cmi : typing/types.cmi typing/typedtree.cmi typing/path.cmi \
typing/typedecl.cmo : utils/warnings.cmi typing/typetexp.cmi \
typing/types.cmi typing/typedtree.cmi typing/subst.cmi \
typing/printtyp.cmi typing/primitive.cmi typing/predef.cmi \
typing/path.cmi parsing/parsetree.cmi utils/misc.cmi \
typing/path.cmi parsing/parsetree.cmi typing/oprint.cmi utils/misc.cmi \
parsing/longident.cmi parsing/location.cmi typing/includecore.cmi \
typing/ident.cmi typing/env.cmi typing/datarepr.cmi typing/ctype.cmi \
utils/config.cmi utils/clflags.cmi parsing/builtin_attributes.cmi \
Expand All @@ -415,7 +415,7 @@ typing/typedecl.cmo : utils/warnings.cmi typing/typetexp.cmi \
typing/typedecl.cmx : utils/warnings.cmx typing/typetexp.cmx \
typing/types.cmx typing/typedtree.cmx typing/subst.cmx \
typing/printtyp.cmx typing/primitive.cmx typing/predef.cmx \
typing/path.cmx parsing/parsetree.cmi utils/misc.cmx \
typing/path.cmx parsing/parsetree.cmi typing/oprint.cmx utils/misc.cmx \
parsing/longident.cmx parsing/location.cmx typing/includecore.cmx \
typing/ident.cmx typing/env.cmx typing/datarepr.cmx typing/ctype.cmx \
utils/config.cmx utils/clflags.cmx parsing/builtin_attributes.cmx \
Expand Down Expand Up @@ -491,18 +491,18 @@ typing/types.cmi : typing/primitive.cmi typing/path.cmi \
typing/ident.cmi parsing/asttypes.cmi
typing/typetexp.cmo : typing/types.cmi typing/typedtree.cmi utils/tbl.cmi \
typing/printtyp.cmi typing/predef.cmi typing/path.cmi \
parsing/parsetree.cmi utils/misc.cmi parsing/longident.cmi \
parsing/location.cmi typing/includemod.cmi typing/env.cmi \
typing/ctype.cmi utils/clflags.cmi parsing/builtin_attributes.cmi \
typing/btype.cmi parsing/asttypes.cmi parsing/ast_helper.cmi \
typing/typetexp.cmi
parsing/parsetree.cmi typing/oprint.cmi utils/misc.cmi \
parsing/longident.cmi parsing/location.cmi typing/includemod.cmi \
typing/env.cmi typing/ctype.cmi utils/clflags.cmi \
parsing/builtin_attributes.cmi typing/btype.cmi parsing/asttypes.cmi \
parsing/ast_helper.cmi typing/typetexp.cmi
typing/typetexp.cmx : typing/types.cmx typing/typedtree.cmx utils/tbl.cmx \
typing/printtyp.cmx typing/predef.cmx typing/path.cmx \
parsing/parsetree.cmi utils/misc.cmx parsing/longident.cmx \
parsing/location.cmx typing/includemod.cmx typing/env.cmx \
typing/ctype.cmx utils/clflags.cmx parsing/builtin_attributes.cmx \
typing/btype.cmx parsing/asttypes.cmi parsing/ast_helper.cmx \
typing/typetexp.cmi
parsing/parsetree.cmi typing/oprint.cmx utils/misc.cmx \
parsing/longident.cmx parsing/location.cmx typing/includemod.cmx \
typing/env.cmx typing/ctype.cmx utils/clflags.cmx \
parsing/builtin_attributes.cmx typing/btype.cmx parsing/asttypes.cmi \
parsing/ast_helper.cmx typing/typetexp.cmi
typing/typetexp.cmi : typing/types.cmi typing/typedtree.cmi typing/path.cmi \
parsing/parsetree.cmi parsing/longident.cmi parsing/location.cmi \
typing/includemod.cmi typing/env.cmi parsing/asttypes.cmi
Expand Down Expand Up @@ -2328,10 +2328,10 @@ toplevel/opttoploop.cmo : utils/warnings.cmi typing/types.cmi \
parsing/lexer.cmi bytecomp/lambda.cmi typing/includemod.cmi \
asmcomp/import_approx.cmi typing/ident.cmi toplevel/genprintval.cmi \
typing/env.cmi utils/config.cmi driver/compmisc.cmi asmcomp/compilenv.cmi \
driver/compdynlink.cmi utils/clflags.cmi typing/btype.cmi \
middle_end/backend_intf.cmi parsing/asttypes.cmi parsing/ast_helper.cmi \
asmcomp/asmlink.cmi asmcomp/asmgen.cmi asmcomp/arch.cmo \
toplevel/opttoploop.cmi
driver/compenv.cmi driver/compdynlink.cmi utils/clflags.cmi \
typing/btype.cmi middle_end/backend_intf.cmi parsing/asttypes.cmi \
parsing/ast_helper.cmi asmcomp/asmlink.cmi asmcomp/asmgen.cmi \
asmcomp/arch.cmo toplevel/opttoploop.cmi
toplevel/opttoploop.cmx : utils/warnings.cmx typing/types.cmx \
typing/typemod.cmx typing/typedtree.cmx typing/typecore.cmx \
bytecomp/translmod.cmx bytecomp/simplif.cmx asmcomp/proc.cmx \
Expand All @@ -2343,23 +2343,21 @@ toplevel/opttoploop.cmx : utils/warnings.cmx typing/types.cmx \
parsing/lexer.cmx bytecomp/lambda.cmx typing/includemod.cmx \
asmcomp/import_approx.cmx typing/ident.cmx toplevel/genprintval.cmx \
typing/env.cmx utils/config.cmx driver/compmisc.cmx asmcomp/compilenv.cmx \
driver/compdynlink.cmi utils/clflags.cmx typing/btype.cmx \
middle_end/backend_intf.cmi parsing/asttypes.cmi parsing/ast_helper.cmx \
asmcomp/asmlink.cmx asmcomp/asmgen.cmx asmcomp/arch.cmx \
toplevel/opttoploop.cmi
driver/compenv.cmx driver/compdynlink.cmi utils/clflags.cmx \
typing/btype.cmx middle_end/backend_intf.cmi parsing/asttypes.cmi \
parsing/ast_helper.cmx asmcomp/asmlink.cmx asmcomp/asmgen.cmx \
asmcomp/arch.cmx toplevel/opttoploop.cmi
toplevel/opttoploop.cmi : utils/warnings.cmi typing/types.cmi \
typing/path.cmi parsing/parsetree.cmi typing/outcometree.cmi \
parsing/longident.cmi parsing/location.cmi typing/env.cmi
toplevel/opttopmain.cmo : utils/warnings.cmi asmcomp/printmach.cmi \
toplevel/opttoploop.cmi toplevel/opttopdirs.cmi utils/misc.cmi \
driver/main_args.cmi parsing/location.cmi utils/config.cmi \
driver/compmisc.cmi driver/compenv.cmi utils/clflags.cmi \
toplevel/opttopmain.cmi
toplevel/opttoploop.cmi toplevel/opttopdirs.cmi driver/main_args.cmi \
parsing/location.cmi driver/compmisc.cmi driver/compenv.cmi \
utils/clflags.cmi toplevel/opttopmain.cmi
toplevel/opttopmain.cmx : utils/warnings.cmx asmcomp/printmach.cmx \
toplevel/opttoploop.cmx toplevel/opttopdirs.cmx utils/misc.cmx \
driver/main_args.cmx parsing/location.cmx utils/config.cmx \
driver/compmisc.cmx driver/compenv.cmx utils/clflags.cmx \
toplevel/opttopmain.cmi
toplevel/opttoploop.cmx toplevel/opttopdirs.cmx driver/main_args.cmx \
parsing/location.cmx driver/compmisc.cmx driver/compenv.cmx \
utils/clflags.cmx toplevel/opttopmain.cmi
toplevel/opttopmain.cmi :
toplevel/opttopstart.cmo : toplevel/opttopmain.cmi
toplevel/opttopstart.cmx : toplevel/opttopmain.cmx
Expand Down Expand Up @@ -2414,15 +2412,13 @@ toplevel/toploop.cmi : utils/warnings.cmi typing/types.cmi typing/path.cmi \
parsing/parsetree.cmi typing/outcometree.cmi parsing/longident.cmi \
parsing/location.cmi typing/env.cmi
toplevel/topmain.cmo : utils/warnings.cmi toplevel/toploop.cmi \
toplevel/topdirs.cmi utils/profile.cmi utils/misc.cmi \
driver/main_args.cmi parsing/location.cmi utils/config.cmi \
driver/compmisc.cmi driver/compenv.cmi utils/clflags.cmi \
toplevel/topmain.cmi
toplevel/topdirs.cmi utils/profile.cmi driver/main_args.cmi \
parsing/location.cmi driver/compmisc.cmi driver/compenv.cmi \
utils/clflags.cmi toplevel/topmain.cmi
toplevel/topmain.cmx : utils/warnings.cmx toplevel/toploop.cmx \
toplevel/topdirs.cmx utils/profile.cmx utils/misc.cmx \
driver/main_args.cmx parsing/location.cmx utils/config.cmx \
driver/compmisc.cmx driver/compenv.cmx utils/clflags.cmx \
toplevel/topmain.cmi
toplevel/topdirs.cmx utils/profile.cmx driver/main_args.cmx \
parsing/location.cmx driver/compmisc.cmx driver/compenv.cmx \
utils/clflags.cmx toplevel/topmain.cmi
toplevel/topmain.cmi :
toplevel/topstart.cmo : toplevel/topmain.cmi
toplevel/topstart.cmx : toplevel/topmain.cmx
Expand Down
2 changes: 1 addition & 1 deletion driver/compenv.ml
Expand Up @@ -205,7 +205,7 @@ let read_one_param ppf position name v =
| "afl-inst-ratio" ->
int_setter ppf "afl-inst-ratio" afl_inst_ratio v
| "annot" -> set "annot" [ Clflags.annotations ] v
| "absname" -> set "absname" [ Location.absname ] v
| "absname" -> set "absname" [ Clflags.absname ] v
| "compat-32" -> set "compat-32" [ bytecode_compatible_32 ] v
| "noassert" -> set "noassert" [ noassert ] v
| "noautolink" -> set "noautolink" [ no_auto_link ] v
Expand Down
2 changes: 1 addition & 1 deletion driver/main.ml
Expand Up @@ -25,7 +25,7 @@ module Options = Main_args.Make_bytecomp_options (struct
let set r () = r := true
let unset r () = r := false
let _a = set make_archive
let _absname = set Location.absname
let _absname = set Clflags.absname
let _annot = set annotations
let _binannot = set binary_annotations
let _c = set compile_only
Expand Down
2 changes: 1 addition & 1 deletion driver/makedepend.ml
Expand Up @@ -550,7 +550,7 @@ let main () =
Compenv.readenv ppf Before_args;
Clflags.reset_arguments (); (* reset arguments from ocamlc/ocamlopt *)
Clflags.add_arguments __LOC__ [
"-absname", Arg.Set Location.absname,
"-absname", Arg.Set Clflags.absname,
" Show absolute filenames in error messages";
"-all", Arg.Set all_dependencies,
" Generate dependencies on all files";
Expand Down
2 changes: 1 addition & 1 deletion driver/optmain.ml
Expand Up @@ -41,7 +41,7 @@ module Options = Main_args.Make_optcomp_options (struct
let clear r () = r := false

let _a = set make_archive
let _absname = set Location.absname
let _absname = set Clflags.absname
let _afl_instrument = set afl_instrument
let _afl_inst_ratio n = afl_inst_ratio := n
let _annot = set annotations
Expand Down
2 changes: 1 addition & 1 deletion ocamldoc/odoc_args.ml
Expand Up @@ -199,7 +199,7 @@ let anonymous f =
module Options = Main_args.Make_ocamldoc_options(struct
let set r () = r := true
let unset r () = r := false
let _absname = set Location.absname
let _absname = set Clflags.absname
let _I s = Odoc_global.include_dirs := s :: !Odoc_global.include_dirs
let _impl s = Odoc_global.files := !Odoc_global.files @ [Odoc_global.Impl_file s]
let _intf s = Odoc_global.files := !Odoc_global.files @ [Odoc_global.Intf_file s]
Expand Down
6 changes: 1 addition & 5 deletions parsing/location.ml
Expand Up @@ -15,10 +15,6 @@

open Lexing

let absname = ref false
(* This reference should be in Clflags, but it would create an additional
dependency and make bootstrapping Camlp4 more difficult. *)

type t = Warnings.loc =
{ loc_start: position; loc_end: position; loc_ghost: bool };;

Expand Down Expand Up @@ -274,7 +270,7 @@ let absolute_path s = (* This function could go into Filename *)
aux s

let show_filename file =
if !absname then absolute_path file else file
if !Clflags.absname then absolute_path file else file

let print_filename ppf file =
Format.fprintf ppf "%s" (show_filename file)
Expand Down
2 changes: 0 additions & 2 deletions parsing/location.mli
Expand Up @@ -103,8 +103,6 @@ val show_filename: string -> string
Otherwise, returns the filename unchanged. *)


val absname: bool ref

(** Support for located errors *)

type error =
Expand Down
2 changes: 1 addition & 1 deletion toplevel/topmain.ml
Expand Up @@ -100,7 +100,7 @@ module Options = Main_args.Make_bytetop_options (struct
let set r () = r := true
let clear r () = r := false

let _absname = set Location.absname
let _absname = set Clflags.absname
let _I dir = include_dirs := dir :: !include_dirs
let _init s = init_file := Some s
let _noinit = set noinit
Expand Down
1 change: 1 addition & 0 deletions utils/clflags.ml
Expand Up @@ -63,6 +63,7 @@ and nopervasives = ref false (* -nopervasives *)
and match_context_rows = ref 32 (* -match-context-rows *)
and preprocessor = ref(None : string option) (* -pp *)
and all_ppx = ref ([] : string list) (* -ppx *)
let absname = ref false (* -absname *)
let annotations = ref false (* -annot *)
let binary_annotations = ref false (* -annot *)
and use_threads = ref false (* -thread *)
Expand Down
1 change: 1 addition & 0 deletions utils/clflags.mli
Expand Up @@ -91,6 +91,7 @@ val match_context_rows : int ref
val open_modules : string list ref
val preprocessor : string option ref
val all_ppx : string list ref
val absname : bool ref
val annotations : bool ref
val binary_annotations : bool ref
val use_threads : bool ref
Expand Down

0 comments on commit e3f2c54

Please sign in to comment.