Ocamlbuild: make it possible to change the ocamlmklib command #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a -ocamlmklib option. Use ocamlfind for ocamlmklib as well, when told to do so. This is useful when crosscompiling, to select an alternative ocamlmklib that produces libraries for the target platform.
|
The patch looks trivial enough. Did you check that it works as expected with the new code to handle "-use-ocamlfind -ocamlc " (PR#6300)? |
|
The code does the very same thing with ocamlmklib as with other commands. So, I don't see why there would be any issue. |
|
Merged in 4.02, thanks! |
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 14, 2017
chambart
pushed a commit
to chambart/ocaml-1
that referenced
this pull request
Aug 4, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Oct 5, 2021
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Patrick Ferris <pf341@patricoferris.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when cross-compiling, to select an alternative ocamlmklib that produces libraries for the target platform.