runtime events consumer: fix invalid value returned from runtime_events_read_poll #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
approved these changes
Apr 11, 2023
|
Looks good to me, but I'm not sure this deserves a Changes entry. |
|
The Changes entry makes sense to me as this bug might have impacted existing users of runtime events, encountering incorrect behaviors and segmentation faults when using the return value of But I don't have a strong opinion on that matter so it can be removed if needed. |
|
I suspect that the only user of |
gasche
added a commit
that referenced
this pull request
Apr 11, 2023
runtime events consumer: fix invalid value returned from runtime_events_read_poll (cherry picked from commit 54c81e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caml_ml_runtime_events_read_pollis supposed to return an OCaml integer, but the conversion was done the other way around, usingInt_valinstead ofVal_int.cc @sadiqj @Engil