Remove duplicated -lunixbyt in threads.cma #13019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also going through precheck |
|
Precheck is green. Do we want a Changes entry? |
This appears to have been an unnecessary addition when ccopt/cclib were added to cma format: since threads.cma must be linked with unix.cma, -lunixbyt will be specified by the unix library.
dra27
force-pushed
the
linking-stuff-trunk
branch
from
444bb54
to
f1fe086
Compare
|
It definitely ought to - I'm as certain as I can be at the moment, given @shindere's and @alainfrisch's comments in the file (and also just how long the Windows ports have done this without it being a problem) that it'll be fine, but it's doubly embarrassing if something does break and it's not mentioned in Changes 🙈 |
|
That's awesome! Thanks!
|
Octachron
pushed a commit
that referenced
this pull request
Mar 22, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 29, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 29, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 29, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 29, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 30, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 30, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
dra27
pushed a commit
to dra27/ocaml
that referenced
this pull request
Jul 30, 2024
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part of #13018 which still applies to trunk.