-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated -lunixbyt in threads.cma #13019
Conversation
Also going through precheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Precheck is green. Do we want a Changes entry? |
This appears to have been an unnecessary addition when ccopt/cclib were added to cma format: since threads.cma must be linked with unix.cma, -lunixbyt will be specified by the unix library.
444bb54
to
f1fe086
Compare
It definitely ought to - I'm as certain as I can be at the moment, given @shindere's and @alainfrisch's comments in the file (and also just how long the Windows ports have done this without it being a problem) that it'll be fine, but it's doubly embarrassing if something does break and it's not mentioned in Changes 🙈 |
That's awesome! Thanks!
|
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
Remove duplicated -lunixbyt in threads.cma (cherry picked from commit 179ccfe)
This is the part of #13018 which still applies to trunk.