Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self pattern variable location tweak for OCaml 4.00.0 beta #5654

Closed
vicuna opened this issue Jun 19, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Jun 19, 2012

Original bug ID: 5654
Reporter: furuse
Assigned to: @garrigue
Status: closed (set by @garrigue on 2012-06-19T10:45:32Z)
Resolution: fixed
Priority: normal
Severity: tweak
Fixed in version: 4.00.0+beta2/+rc1
Category: ~DO NOT USE (was: OCaml general)

Bug description

During porting OCamlSpotter to 4.00.0, I found the hidden function argument self-n for methods are defined with noloc.

This is sad for I and probably OCamlPro guys who work on tools like OCamlSpotter and TypeRex. It would be nice if their locations are equal to the corresponding (self) parameters at object (self). I put a patch for it. The patch only fixes the location of self-n. Probably self-*'s location should be fixed too.

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented Jun 19, 2012

Comment author: @garrigue

Applied slightly modified patch (using ghost locations, and self-* too) to trunk and 4.00, at revision 12614.
Note that self-* is less important, since it is used by overriding, so that there is no guarantee that there is an actual location, and moreover overriding applies only to the current object (not an enclosing one, like for variable accesses).

@vicuna vicuna closed this Jun 19, 2012

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.