-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamldep is broken (especially when you use first class module) #5738
Comments
Comment author: @garrigue Fixed in trunk and 4.00, revisions 12878 and 12879. |
Comment author: @lefessan Are you sure it is fixed ? Compiling latest SVN does not solve the problem for me: $ touch a.ml |
Comment author: @lefessan Jacques, could you check if it is fixed, and maybe try my patch that I was about to submit (attached to the bug report). |
Comment author: @garrigue Sorry, I got confused by Ppat_type :-) |
Comment author: @lefessan and add_bindings recf bv pel =
Isn't it let bv = if recf = Recursive then bv' else bv in instead ? |
Comment author: @garrigue Sorry, I'm too sleepy today. By the way, the use of a mutable variable for patterns is intentional: |
Original bug ID: 5738
Reporter: @bobzhang
Assigned to: @garrigue
Status: closed (set by @garrigue on 2012-08-25T11:37:33Z)
Resolution: fixed
Priority: normal
Severity: major
Fixed in version: 4.00.1+dev
Category: tools (ocaml{lex,yacc,dep,debug,...})
Bug description
let f (module A : B) =
A.v ;;
will generate dependency on module A, actually not. If you happens to have a file A.ml(very likely), it will tries to compile module A. Reading the mantis quite a bit, I found this is a long existing problem. Things become worse if you use first class modules a lot. Is there solutions to work around such problem?
I set the severity to be major, because it nearly breaks all my existing repos when I switched to first class modules.
Many thanks
File attachments
The text was updated successfully, but these errors were encountered: