Shorten symbol names of anonymous functions in Flambda mode #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this also fixes #7895 |
|
Most probably, yes. |
mshinwell
force-pushed
the
flambda_name_mangling
branch
from
74ae615
to
c843e2d
Compare
|
@nojb Actually, are you in a position to approve this? I think it can be merged without waiting for CI again, the change is local and the only CI failure was on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precheck fails on #2268 not only because of #8506 but also because of some excessively long symbol names. These cause trouble on Windows platforms where there is a length limit on such things. The symbol names correspond to anonymous functions, whose names for convenience are equipped with the source filename and location. I have changed these names in this patch to strip any directory names, which should reduce problems in this area with very deeply nested directory structures and/or use of
-absname.In the future, the actual names of symbols won't really be relevant any more, since the DWARF information will enable debuggers and other tools to reconstruct proper names even for anonymous functions. (Furthermore, I believe the current namespacing proposals of @lpw25 are going to yield symbols that to a first approximation are just hashes.)
I will add a Changes entry to this in due course, since this is user-visible.