Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables in exported Makefile.config contain calls to macros #8703

Closed
garrigue opened this issue May 31, 2019 · 2 comments
Closed

Variables in exported Makefile.config contain calls to macros #8703

garrigue opened this issue May 31, 2019 · 2 comments

Comments

@garrigue
Copy link
Contributor

The Makefile.config exported by OCaml 4.08.0+rc1 contains calls to macros.
This prevents easy extraction of variables using grep, as it was done in labltk for instance.
@dra27
Copy link
Member

dra27 commented Jun 11, 2019

This is a consequence of the switch to autoconf, and next to impossible to workaround.

The solution I see you've committed in garrigue/labltk@390c2c8 is the template for this, and elsewhere.

The other option might be to do something to "simplify" the Makefile.config file which is installed, but it feels like we've missed the boat for that only picking up on it during the RC stage of 4.08.

@xavierleroy
Copy link
Contributor

The workaround (include Makefile.config rather than grep through it) is fine. I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garrigue @xavierleroy @dra27