More compatibility macros to Caml_state #9202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, one thing that puzzles me is that Delimcc's |
oh yes it's the "very minimal change" I was talking about. I was a bit puzzled on the role of |
|
Ok, thanks. So, if I understand correctly, with this patch and #9167, delimcc compiles without a change. |
It's better to keep the "one #define per line" style than to introduce line breaks there.
xavierleroy
pushed a commit
that referenced
this pull request
Dec 26, 2019
runtime/caml/compatibility.h: Add compatibility macros for globals that have been moved to Caml_state. Some of these globals are used by 3rd-party libraries, e.g. delimcc .gitattributes: Tolerate long lines in runtime/caml/compatibility.h. It's better to keep the "one #define per line" style than to introduce line breaks there. (cherry picked from commit 073fcbb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8713 moved a bunch of globals to the new
Caml_statestructure. This change in the C API breaks a number of packages that were using them.To facilitate this change, compatibility macros have been introduced, however some of them were missing. This PR adds every remaining previously accessible globals that didn't change their type.
The only missing fields from
Caml_stateare:caml_young_basewhich was previously a static variable inminor_gc.ccaml_ref_table,caml_ephe_ref_tableandcaml_custom_tablewhich were previously global structures and not structure pointersI've been noticing the missing globals when I tried to make Oleg Kiselyov's
delimcccompile with OCaml 4.10. With at least the first commit from this PR, it compiles with very minimal change.