Avoid looking up nonexistent Comballoc debuginfo #9362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
approved these changes
Mar 17, 2020
| (*ptrace)[trace_pos++] = Val_backtrace_slot(Slot_debuginfo(info)); | ||
| } else { | ||
| (*ptrace)[trace_pos++] = Val_backtrace_slot(Slot_frame_descr(descr)); | ||
| } |
There was a problem hiding this comment.
I would have written the (info == NULL) case first (it is shorter and also it makes sense to have it first) but this is extreme nitpicking.
stedolan
added a commit
to janestreet/ocaml
that referenced
this pull request
Mar 17, 2020
…e5452) Avoid looking up nonexistent Comballoc debuginfo
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Apr 7, 2020
…e5452) Avoid looking up nonexistent Comballoc debuginfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor bugfix for #9230. For allocations subject to combining, #9230 stores a pointer to the debuginfo instead of the frametable in backtraces, because the same frametable entry might refer to several allocations from different locations that have been combined.
The bug is that there might not be a debuginfo! In such cases, we should store the frametable entry, to at least get a unique ID for the allocation site rather than a null pointer.
Even when everything is compiled with
-g, this still occurs for internally-generated functions (caml_apply2, etc.), for which no debuginfo is generated.cc @jhjourdan, @gasche