-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named text sections for caml_system__code_begin/end symbols #9631
Named text sections for caml_system__code_begin/end symbols #9631
Conversation
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
388524f
to
2955400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the patch is correct. Though I am not familiar with other platforms (I was not even aware of \name
syntax on ARM64).
Thank you @let-def for your review. Does this PR need a Changes entry? |
c4da8d3
to
1e91d2b
Compare
(Note for @lpw25: we also expect a backport in 4.12.) |
…m_code Named text sections for caml_system__code_begin/end symbols
Cherry-picked to 4.12 as 0046bcb |
…-pick 388524f) Add named text sections for caml_system__code_begin/end symbols
Place the symbols
caml_system__code_begin
andcaml_system__code_end
into their own named text sections.text.caml.caml_system__code_begin
and.text.caml.caml_system__code_end
, respectively, when function sections are enabled. Other symbols that mark begin and end of code segments are already placed their own named text sections.Note that this PR changes the section names for
caml_hot__code_begin
andcaml_hot__code_begin
symbols: they are prefixed with.text.caml
instead of.text
only. The new names are consistent with the section names for other code segment markers. Linker scripts that usecaml_hot__*
symbols will need to be adjusted, but it's probably only used by ocamlfdo.With these changes, the symbols appear in the correct order in the executable:
instead of
when linked with default linkers on Linux systems.
It makes debuggers happy again, as originally intended here:
ocaml/runtime/amd64.S
Lines 308 to 310 in ca64723