Build otherlibs with debug info in C stubs #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! thanks!
|
shindere
approved these changes
Jul 27, 2020
|
|
stedolan
force-pushed
the
otherlibs-debug
branch
from
6f0c7d1
to
83bf4ec
Compare
Thanks, done. |
|
Ugh, sorry to come back with another nit, but I do think this warrants a Changes entry, just because some obscure user or packager may notice it! |
stedolan
force-pushed
the
otherlibs-debug
branch
from
83bf4ec
to
a741f25
Compare
|
|
dra27
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unix library and other otherlibs/ denizens don't get
-gon their C stubs, which makes debugging annoying, so this patch adds it. (I copy-pasted the Makefile gunk fromruntime/)