-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Makefile typo #10268
Fix Makefile typo #10268
Conversation
Sorry, this is the wrong fix. By the way I am trying to fix the following warnings (observed in OS X and also in the RISC-V CI at least):
|
My solution to please both check-typo and the undefined Makefile variable warning was to define a separate upper function: |
A variant of this works: --- a/stdlib/StdlibModules
+++ b/stdlib/StdlibModules
@@ -47,6 +47,9 @@ STDLIB_PREFIXED_MODULES=\
# add stdlib__ as prefix to a module except for internal modules
# and the stdlib module itself
+EMPTY=
+SPACE=$(EMPTY) $(EMPTY)
+$(SPACE) :=
define add_stdlib_prefix
$(or $(filter-out $(STDLIB_PREFIXED_MODULES), $1), \
stdlib__$(shell echo $1 | cut -c1 | tr '[:lower:]' '[:upper:]')$\ More shortly... |
I think the `EMPTY` variable is already defined in the build system
so it may not be necessary to define it again here. Perhaps the SPACE
variable can also be defined globally if used in more than one place.
|
Ack - just testing an alternate fix |
Closing this in favor of #10270 |
Following #10169 (I think)