Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Effect.{eff => t} #11044

Merged
merged 2 commits into from Feb 25, 2022
Merged

Rename Effect.{eff => t} #11044

merged 2 commits into from Feb 25, 2022

Conversation

nojb
Copy link
Contributor

@nojb nojb commented Feb 21, 2022

Fixes #11030

@kayceesrk kayceesrk mentioned this pull request Feb 21, 2022
Merged
gasche
gasche approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is consensus to do this, so let's move on!

@nojb
Copy link
Contributor Author

nojb commented Feb 25, 2022

I think there is consensus to do this, so let's move on!

Thanks, I had forgotten to update the tests. This is now done, will merge if the CI passses.

@nojb nojb merged commit 79c6d05 into ocaml:trunk Feb 25, 2022
@nojb nojb deleted the effect_t branch February 25, 2022 14:16
@Sudha247 Sudha247 mentioned this pull request Feb 28, 2022
Merged
EduardoRFS pushed a commit to esy-ocaml/ocaml that referenced this pull request Mar 1, 2022
@nojb @EduardoRFS
Rename Effect.{eff => t} (ocaml#11044)
0c74bbe
patricoferris pushed a commit to patricoferris/ocaml that referenced this pull request Mar 7, 2022
@nojb @patricoferris
Rename Effect.{eff => t} (ocaml#11044)
2dcf16c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasche gasche gasche approved these changes

Assignees
No one assigned
Labels
no-change-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is it 'a Effect.eff and not 'a Effect.t ?
2 participants
@nojb @gasche