Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamltest: keep debug information for all C files #11153

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

shindere
Copy link
Contributor

@shindere shindere commented Apr 1, 2022

This is a follow-up to #11111 by @gasche.

What 9ee4c07 does is not correct because
CFLAGS and the like are for the user. Then should be used by the
build-system where appropriate, but never ever should they be defined.

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks for the fix.

@gasche gasche merged commit 54c85c8 into ocaml:trunk Apr 1, 2022
@shindere
Copy link
Contributor Author

shindere commented Apr 1, 2022 via email

@shindere
Copy link
Contributor Author

shindere commented Apr 1, 2022 via email

@shindere
Copy link
Contributor Author

shindere commented Apr 1, 2022 via email

@shindere shindere deleted the fix-ocamltest-debug branch April 1, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants