Limit bit-rot in the disabled backends #11217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While getting the other-checks stage to pass again in #11183, I disabled the CI checks for the presently disabled native code backends. While they may not be working, I think it's probably worth having
make check_all_arches
at least limit the bit-rot by ensuring that they continue to be compile, even if the code they produce is nonsense.This PR:
Iload
for the changes in Introduce atomic loads in Cmm and Mach IRs #10943 in all the disabled backendsIextcall
in the arm emitter for (type) compatibility with multicoreDomainstate.Domain_exception_pointer
toDomainstate.Domain_exn_handler
between Move C global variables to a dedicated structure #8713 and the multicore merge to the i386 backendassert false
placeholders forIdls_get
to all the disabled backendsTogether, these changes restore
make check_all_arches