-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix10768 #11340
Fix10768 #11340
Conversation
Thanks. |
@garrigue : do you plan to cherry-pick the fix to the 5.0 branch later, or should I take care of it? |
I'll do it just now. |
Fix #10768: typechecking regression when combining first class modules and GADTs.
That sounds reasonable to me, #10364 is a rather old bug fix that was frozen during multicore integration. It makes sense to integrate it before the first alpha but let's ask for @trefis's opinion as the reviewer. However, looking at the testsuite changes for #10364, I only see functions with improved error messages, one function that now type in non-principal mode, and two functions that type in principal mode but with a warning. Do you have an example of a program that no longer typecheck? |
You're right. The principal mode is stricter, but only for warnings, so this makes sense to cherry-pick it. |
…request PR#12198 from shindere/merge-debugger-makefile Merge debugger/Makefile into the root Makefile
This is an alternative fix to #10768.
Compared to #11339, it duplicates types of first class modules, the same way as in
Typecore.type_cases
, rather than disabling scope checking, which is potentially dangerous.