Correct CAMLextern in headers #11577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAMLextern used on declarations instead of CAMLprim
shindere
approved these changes
Sep 27, 2022
|
Thanks, @shindere! |
dra27
added a commit
that referenced
this pull request
Sep 27, 2022
Correct CAMLextern in headers (cherry picked from commit c534f97)
|
This looks good to me, thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
CAMLexternand which therefore can fail to be relocated by flexdllI've resurrected some of my previous work on fvisibility to test that these are the only functions remaining which need
CAMLexterndecorations. Fully resurrecting that is for another day, though...