Temporarily disable the lib-dynlink-domains test on Windows #11607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily, until flexdll has been patched for parallel use of dlopen and dlsym.
Octachron
approved these changes
Oct 6, 2022
dra27
added a commit
that referenced
this pull request
Oct 6, 2022
Temporarily disable the lib-dynlink-domains test on Windows (cherry picked from commit 131fbf3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since turning AppVeyor back on, we've been seeing frequent failures in the
lib-dynlink-domainstest from #11032.This test is correctly revealing that FlexDLL is not thread-safe. It's very easy to reproduce the problem - even if the test succeeds, running
main.exefrom theocamlopt.bytetest output directory a few times will reveal one or other of various corruptions! I've verified with a quickly hacked patch that fixingflexdll_wdlopenandflexdll_dlsymfor multi-threaded access eliminates the crash. The lock used in bytecode to protect theSymtablemachinery will be also protecting flexlink when this is executed in bytecode, so this is a native code problem (AppVeyor does run all the dynlink tests in native code for, um, this very reason apparently!)This test fails more regularly than it passes, so until I've patched flexdll, I suggest we disable it on Windows.