Annotate Domain.self with noalloc #12683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
I believe that the change is correct.
(I also checked: cpu_relax is not noalloc as its implementation handles incoming GC requests.)
@sheeraSearch82 if you want to be credited for the change, please add an entry in the Changes file in the "Bug fixes" category, for example:
- #12676, #12683: mark Domain.self as [@@noalloc]
(<your name>, report by Vesa Karvonen, review by Gabriel Scherer)
Otherwise, if you prefer to not have a change entry for this, just say so.
|
"No change entry needed for this one. Thanks @gasche." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12676.