Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toplevel: remove plugin option #1381

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Octachron
Copy link
Member

MPR7570:
This PR removes the non-functional -plugin option from the toplevels, since the option does not work at all currently and should not be exposed to users.

@Octachron Octachron added the bug label Sep 29, 2017
Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing this non-functioning option for the time being. If there is a real need (to be demonstrated), it should be reimplemented not on top of Dynlink but on top of the implementation of #load.

@xavierleroy xavierleroy merged commit f24981d into ocaml:4.06 Sep 30, 2017
@xavierleroy
Copy link
Contributor

Cherry-picked to [trunk 0bf9cea]

EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
* Entire body of the playground page is `display:flex`, and child
  elements take up space within their respective parents. Fixes another
  layout glitch where some parts of the page would be taller than others.
* Resolves ocaml#1381. Text no longer disappears beneath the bar containing the
  "Run" button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants