MPR#7048: ocamldoc -latex, don't escape Latin-1 accented vowels #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes trouble when the doc comments are actually in UTF8 and
the user is providing their own preamble with an UTF8 inputenc.
The default preamble still contains \usepackage[latin1]{inputenc},
so the Latin-1 accents will still display fine.
Octachron
reviewed
Oct 9, 2017
Changes
Outdated
| @@ -349,6 +349,9 @@ Release branch for 4.06: | |||
| when no -title has been provided | |||
| (Pierre Boutillier) | |||
|
|
|||
| - MPR#7048: ocamldoc, in -latex mode, don't escape Latin-1 accented vowels | |||
There was a problem hiding this comment.
Utterly minor nitpicking: ç is not a vowel.
Touché! I fixed the Changes file and will now merge. Thanks for the quick feedback. |
|
Cherry-pick [4.06 6a8c0ec] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes trouble when the doc comments are actually in UTF8 and
the user is providing their own preamble with an UTF8 inputenc.
The default preamble still contains
\usepackage[latin1]{inputenc},so the Latin-1 accents will still display fine.
Original report: https://caml.inria.fr/mantis/view.php?id=7048