Ocamldoc, latex backend: labels for exception #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The label was removed by dcceb46. Could you add an exception declaration to the regression testsuite ? |
This commit fixes the lack of label for exception definition in the latex backend of ocamldoc.
Octachron
force-pushed
the
ocamldoc_latex_exception_label
branch
from
fec6c35
to
44c1bbe
Compare
|
This is clearly needed indeed. I have added an exception definition and some references to the extensible variants test for the latex backend, and fixed the reference file for the inlined record test . |
|
You need a Changes entry, as the label regression is present in released OCaml versions I think. |
|
I added the change entry in the 4.06 section for now. Please tell me if I should move it to trunk. |
|
Cherry-picked in 4.06 ( edb532b ). |
gasche
pushed a commit
that referenced
this pull request
Oct 28, 2017
This commit fixes the lack of label for exception definition in the latex backend of ocamldoc. (cherry picked from commit c0ded0e)
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brief PR restores the label for exceptions in the latex backend of ocamldoc (which fixes a handful of missing reference warnings in the latex version of the manual).