More robust handling of type variables in mcomp #1517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing two types,
Ctype.mcomp
asserts that if neither of them is a variable, then they can't both be expanded to a variable.The first commit adds an example of a code to the testsuite showing that this assertion doesn't hold.
The second commit removes the assertion and handles variables in the exact same way as before expansion of the types.
MPR#6158 and the related commit seem to confirm that this is the correct fix.
The handling of variables pre-expansion is redundant, but I left it in place to serve as a short-circuit since expansion might be costly.
I however doubt that it will be triggered often in practice, as "external" calls to
mcomp
are always preceeded by calls toreify
.