-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export SUPPORTS_SHARED_LIBRARIES in ocamlc -config #1691
Conversation
I support the feature and believe the implementation is correct. Do we get five minutes to discuss whether ( |
I um'd and ah'd over the name (it has two names in our code base too - it's different in s.h!). I'm not attached to the name at all, although other booleans (e.g. windows_unicode, flamda) have similarly non-Boolean names. I'm in no particular rush for this to be merged, so happy to wait for |
I tend to think it would be better to keep this patch consistent as regards naming, so the config dump should be "supports_shared_libraries". @dra27 Can you make this change and then merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(independently of the naming discussion, here is a magical seal of approval.)
ff9f818
to
4aabef3
Compare
@mshinwell - (finally) done. I'll merge when CI passes. |
* autofocus search input on package search results page * on package overview page: add tabindex="1" to in-package search input * move package search input in top navbar earlier in the DOM so it gets tab focus earlier * add OpenSearch manifest for package search
Exposes
SUPPORTS_SHARED_LIBRARIES
fromMakefile.config
asshared_libraries
inocamlc -config