Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -open option to ocamldoc man page #1887

Merged
merged 2 commits into from Jul 6, 2018
Merged

Conversation

tbrk
Copy link
Contributor

@tbrk tbrk commented Jul 6, 2018

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why! Thanks a lot for the quick fix. I'm accepting in principle, but see minor comment below.

man/ocamldoc.m Outdated
@@ -236,6 +236,11 @@ is a list of complete module names are separated by commas (,),
.BR \-latex , \ \-texi ,\ or \ \-dot
options.
.TP
.BI \-open \ module
Opens
.IR module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of the groff manual is that this should be .I rather than .IR, the latter being a two-argument macro -- we used it below with the second argument being a dot, I think.

@tbrk
Copy link
Contributor Author

tbrk commented Jul 6, 2018

Right you are. It's been years since I knew how to write troff/groff.

@gasche gasche merged commit 6226005 into ocaml:trunk Jul 6, 2018
@gasche
Copy link
Member

gasche commented Jul 6, 2018

Merged, thanks!

@tbrk tbrk deleted the ocamldoc-open branch July 6, 2018 09:49
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants