ocamltest: avoid unnecessary rebuilding

[nojb]

You may have noticed that ocamltest is repeatedly rebuilt even when there are no pending changes. It is due to some "intermediate" files being removed at the end of the build (read https://www.gnu.org/software/make/manual/html_node/Chained-Rules.html to understand why). The following PR just marks the relevant files so that they are not removed, so that they don't have to be recreated each time (which triggers the rebuild).

Happy building!

[dra27]

Thanks for doing this, @nojb! I’d noticed it when working on ocamltest, but not for around to fixing it!

Do we have .SECONDARY rules elsewhere for lexers, or is there something specific about the rules in the ocamltest Makefile?

[nojb]

No, I don't think there are other instances. I believe here the issue is a side-effect of the "pattern rules"

%.ml %.mli: %.mly
	$(ocamlyacc) $<

%.ml: %.mll
	$(ocamllex) -q $<

in the ocamltest Makefile.

[shindere]

@nojb many thanks for having spotted this!

Regarding the implementation, rather than hardcoding the names of
the files, could you please the predefined variables?

For instance:

.SECONDARY: $(lexers:.mll=.ml) $(parsers:.mly=.mli) $(parsers:.mly=.ml)

Thanks!

[nojb]

Done.

[shindere]

Nicolás Ojeda Bär (2019/01/21 06:12 -0800):

Done.

Thanks! Merged.