Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis build ocamlnat #445

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Conversation

chambart
Copy link
Contributor

To prevent ocamlnat from being continuously broken, I suggest that we should add it to the travis script.
This is minimal (as we don't test if it works). For a better test, we should probably have an --with-ocamlnat configure flag to build it in make world and be able to test its presence in the testsuite makefiles.

@gasche
Copy link
Member

gasche commented Feb 1, 2016

The question is: who is willing to take the responsibility to fix it when it breaks? @chambart? @trefis? @mshinwell? It would be important to have at least one person to complain to when it breaks.

@trefis
Copy link
Contributor

trefis commented Feb 1, 2016

That's feels like a silly question.
If I go modify something somewhere and it breaks the compilation of typecore.ml you wouldn't expect me to say "well Jacques, I have a present for you, enjoy.".

:)

That being said I'm probably the one who cares most about ocamlnat and I'm fine with looking over it/helping people fix it.

@mshinwell
Copy link
Contributor

@gasche : @trefis is hereby volunteered

@damiendoligez damiendoligez added this to the 4.03.0 milestone Feb 1, 2016
mshinwell added a commit that referenced this pull request Feb 1, 2016
@mshinwell mshinwell merged commit 58b4ae8 into ocaml:trunk Feb 1, 2016
@gasche
Copy link
Member

gasche commented Feb 1, 2016

@trefis : I think you are correct in that my question was not very
well framed. I suspect people that need to touch this piece of code
may want to know who they can ask for guidance -- and someone
to review pull requests touching this code.

Thinking more about this (your fault!), I think that the current state
of extreme duplication of the two codebase means that the maintenance
burden on contributors is high. It's not really that changes affecting
ocamlnat would be difficult; on the contrary, in most cases they would
be exact copies of those touching the toplevel, and this is painfully
boring
.

If it was my call (it isn't), I would not ask contributors to keep
this piece of code updated before we merge some serious attempt at
factoring the bytecode and native toplevel codebases.

@trefis
Copy link
Contributor

trefis commented Feb 2, 2016

I think that the current state of extreme duplication of the two codebase means that the maintenance
burden on contributors is high. It's not really that changes affecting ocamlnat would be difficult; on the contrary, in most cases they would be exact copies of those touching the toplevel, and this is painfully boring.

I agree with you there.
Apart from my old attempt I haven't looked at this at all, but I hope to be able to spend some time after the release to clean things up and factorize. I've previously refrained from doing so because I didn't really know how things where going to evolve w.r.t. flambda.

lukemaurer added a commit to lukemaurer/ocaml that referenced this pull request May 17, 2021
chambart pushed a commit to chambart/ocaml-1 that referenced this pull request Jan 4, 2022
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
* Use ood's static modules

* Add TOC

* Add ood content to repository

* Fix Ood unicode content

* Fix media links

* Address PR reviews
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants