Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper #help for toplevel and #show #46

Closed
wants to merge 3 commits into from
Closed

Proper #help for toplevel and #show #46

wants to merge 3 commits into from

Conversation

berke
Copy link

@berke berke commented Apr 27, 2014

@lpw25
Copy link
Contributor

lpw25 commented May 1, 2014

The #show directive has been split into separate directives (e.g. #show_module) as well as a standalone directive taking a single argument (i.e. #show foo shows everything named foo). So there is no more need for your #show help directive.

@gasche
Copy link
Member

gasche commented Nov 22, 2015

I would like to move forward and merge the pull request. @berke , could you add a Changes entry in the "Toplevel and debugger" section? (Entries are sorted by PR number).

@berke
Copy link
Author

berke commented Dec 9, 2015

Added a Changes entry for PR#6113.

@gasche
Copy link
Member

gasche commented Dec 9, 2015

Thanks @berke . I rebased your changes against trunk in 70ee3c4 in a personal branch toplevel-branch. One remaining issue is that you use tabulation boxes that were deprecated by Pierre Weis during this development cycle. Could you maybe rework the dir_help code to print it in a different way?

@berke
Copy link
Author

berke commented Dec 16, 2015

Hi Gabriel,

I didn't see any Format functionality to replace the tabs, so I have added a few lines of code to calculate column widths manually.

@damiendoligez damiendoligez added this to the 4.03.0 milestone Dec 23, 2015
gasche added a commit that referenced this pull request Dec 25, 2015
@gasche
Add #help directive to the toplevel.
43c31e4 
Nick Giannarakis proposed a first patch at
  http://caml.inria.fr/mantis/view.php?id=6113

Berke Durak and Francis Southern proposed two iterations on the patch
at:
  #46
  #376

The present patch contains code and ideas from all three sources.
@gasche
Copy link
Member

gasche commented Dec 25, 2015

Merged in trunk after some changes following #376 and personal bike-shedding. Thanks!

@gasche gasche closed this Dec 28, 2015
@UnixJunkie
Copy link
Contributor

thanks to all contributors for this nice, user-friendly, addition to the toplevel

This was referenced Mar 14, 2019
Closed
Closed
Closed
mshinwell referenced this pull request in ocaml-flambda/ocaml Nov 7, 2019
@mshinwell
Merge pull request #46 from lthls/exn_extra_args
53db2e8 
Add support for extra parameters in exception handlers
chambart pushed a commit to chambart/ocaml-1 that referenced this pull request Feb 7, 2020
@mshinwell
Merge pull request ocaml#46 from ocaml-flambda/deleted_code_id_checks
8074145 
Check for usage of deleted code ids
anmolsahoo25 pushed a commit to anmolsahoo25/ocaml that referenced this pull request Aug 25, 2020
@ctk21
Merge pull request ocaml#46 from ctk21/safepoint_fix
bfd5b28 
Move safepoint insertion to just after liveness computation
poechsel pushed a commit to poechsel/ocaml that referenced this pull request Jul 2, 2021
@gretay-js @poechsel
Make matches exhaustive (amd64) (ocaml#46)
236af8d
lpw25 pushed a commit to lpw25/ocaml that referenced this pull request Nov 16, 2021
@stedolan
Remove various FIXMEs (ocaml#46)
103b139 
  - runtime: Already_scanned optimisation is not supported
  - runtime: Backwards local pointers are not possible
  - lambda: make function with no cases fatal
  - typing, lambda: remove various already-fixed FIXMEs
  - lambda: remove / convert to TODO some primitives FIXMEs
  - typing, lambda: remove local lazy support
  - selectgen: allow region fusion across try
stedolan added a commit to stedolan/ocaml that referenced this pull request May 24, 2022
@stedolan
Squashed 'ocaml/' changes from 86526aa..173842c
3126bdc 
173842c Merge flambda-backend changes
ed7eba2 Remove leading space from LINE. (ocaml-flambda/flambda-backend#484)
bd61170 Bump magic numbers (ocaml#5)
c50c47d Add CI builds with local allocations enabled
1412792 Move local allocations support behind '-extension local'
6d8e42a Better tail call behaviour in caml_applyN
c7dac3d Typemod: toplevel bindings escape even if no variables are bound
82d6c3e Several fixes for partial application and currying
d05c70c Pprintast support for new local syntax
e0e62fc Typecheck x |> f y as (f y x), not ((f y) x)
d7e34ce Remove autogeneration of @ocaml.curry
b9a0593 Port ocaml-flambda/flambda-backend#493
0a872d9 Code review fixes from ocaml-flambda/flambda-backend#491
6c168bb Remove local allocation counting
3c6e7f0 Code review fixes from ocaml-flambda/flambda-backend#478
bb97207 Rename Lambda.apply_position
a7cb650 Quieten Makefile when runtime dep files are not present
c656dc9 Merge flambda-backend changes
11b5424 Avoid printing double spaces in function argument lists
7751faa Restore locations to Typedtree.{pat,let}_bound_idents_full
e450b6c add build_ocaml_compiler.sexp
0403bb3 Revert PR 9895 to continue installing VERSION
b3447db Ensure new local attributes are namespaced properly
7f213fc Allow empty functions again
8f22ad8 Bugfix: ensure local domain state is initialised
80f54dd Bugfix for Selectgen with regions
e8133a1 Fix external-external signature inclusion
9840051 Bootstrap
d879f23 Merge remote-tracking branch 'jane/local-reviewed' into local-merge
94454f5 Use Local_store for the local allocations ref
54a164c Create fewer regions, according to typechecking (ocaml#59)
1c2479b Merge flambda-backend changes
ce34678 Fix printing of modes in return types
91f2281 Hook mode variable solving into Btype.snapshot/backtrack
54e4b09 Move Alloc_mode and Value_mode to Btype
ff4611e Merge flambda-backend changes
ce62e45 Ensure allocations are initialised, even dead ones
6b6ec5a Fix the alloc.ml test on 32-bit builds
81e9879 Merge flambda-backend changes
40a7f89 Update repo URL for ocaml-jst, and rename script.
0454ee7 Add some new locally-allocating primitives (ocaml#57)
8acdda1 Reset the local stack pointer in exception handlers (ocaml#56)
8dafa98 Improve typing for (||) and (&&) (ocaml#55)
8c64754 Fix make_check_all_arches (ocaml#54)
b50cd45 Allow arguments to primitives to be local even in tail position (ocaml#53)
cad125d Fix modes from or-patterns (ocaml#50)
4efdb72 Fix tailcalls tests with inlining (ocaml#52)
4a795cb Flambda support (ocaml#49)
74722cb Add [@ocaml.principal] and [@ocaml.noprincipal] attributes, and use in oo.mli
6d7d3b8 Ensure that functions are evaluated after their arguments (flambda-backend ocaml#353)
89bda6b Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412)
a39126a Fix tailcalls within regions (ocaml#48)
4ac4cfd Fix stdlib manpages build
3a95f5e Merge flambda-backend changes
efe80c9 Add jane/pull-flambda-patches script
fca94c4 Register allocations for Omitted parameter closures (ocaml#47)
103b139 Remove various FIXMEs (ocaml#46)
62ba2c1 Bootstrap
a0062ad Allow local allocations for various primitives (ocaml#43)
7a2165e Allow primitives to be poly-moded (ocaml#43)
2af3f55 Fix a flaky test by refactoring TypePairs (ocaml#10638)
58dd807 Bootstrap
ee3be10 Fix modes in build_apply for partial applications
fe73656 Tweak for evaluation order of labelled partial applications (ocaml#10653)
0527570 Fix caml_modify on local allocations (ocaml#40)
e657e99 Relax modes for `as` patterns (ocaml#42)
f815bf2 Add special mode handling for tuples in matches and let bindings (ocaml#38)
39f1211 Only take the upper bounds of modes associated with allocations (ocaml#37)
aec6fde Interpret arrow types in "local positions" differently
c4f3319 Bootstrap
ff6fdad Add some missing regions
40d586d Bootstrap
66d8110 Switch to a system with 3 modes for values
f2c5a85 Bugfix for Comballoc with local allocations. (ocaml#41)
83bcd09 Fix bug with root scanning during compaction (ocaml#39)
1b5ec83 Track modes in Lambda.lfunction and onwards (ocaml#33)
f1e2e97 Port ocaml#10728
56703cd Port ocaml#10081
eb66785 Support local allocations in i386 and fix amd64 bug (ocaml#31)
c936b19 Disallow local recursive non-functions (ocaml#30)
c7a193a GC support for local allocations (ocaml#29)
8dd7270 Nonlocal fields (ocaml#28)
e19a2f0 Bootstrap
694b9ac Add syntax to the parser for local allocations (ocaml#26)
f183008 Lower initial stack size
918226f Allow local closure allocations (ocaml#27)
2552e7d Introduce mode variables (ocaml#25)
bc41c99 Minor fixes for local allocations (ocaml#24)
a2a4e60 Runtime and compiler support for more local allocations (ocaml#23)
d030554 Typechecking for local allocations (ocaml#21)
9ee2332 Bugfix missing from ocaml#20
02c4cef Retain block-structured local regions until Mach.
86dbe1c amd64: Move stack realloc calls out-of-line
324d218 More typing modes and locking of environments
a4080b8 Initial version of local allocation (unsafe)

git-subtree-dir: ocaml
git-subtree-split: 173842c
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Mar 21, 2023
@riaqn
Squashed 'ocaml/' changes from a09392d..c703f5f777
bcec5fe 
c703f5f777 Incorporate upstream comments into type-variable refactor (ocaml#121)
362ba2349f Constrain curry modes to increase along applications (ocaml#108)
b1f0cf9f91 Simplify the extension handling (ocaml#114)
4fd53a1f6f Remove pat_mode from typedtree (ocaml#105)
cf6fcbc129 Handle attributes on lambdas with locally abstract types (ocaml#120)
5fa80fe23f Don't track attributes inside attributes for warning 53 (ocaml#115)
8a69777a3c Handle unclosed `[: ... :]` patterns (via `Generic_array` machinery) (ocaml#117)
b0737f46c4 Add promote-one Makefile target (ocaml#118)
c6ad684608 Refactoring and fixes around module lookup (ocaml#107)
b0a649516b Add documentation for global constructor arguments (ocaml#69)
dd79aeca91 Print `nlocal` in the `-d(raw)lambda` output (ocaml#112)
8035026661 Fix `nlocal` in the generated Lambda for list comprehensions (ocaml#113)
afbcdf0642 Immutable arrays (ocaml#47)
bfe1490dfb fix several issues when removing exp_mode (ocaml#110)
8f46060dc5 Better error message for under-applied functions (ocaml#74)
27331d848d Consistently use Lmutvar or Lvar in comprehensions (ocaml#111)
01e965b549 Skip failing test for now
0131357265 Fix test case to use comprehensions_experimental
22a73684b7 Temporarily disable list comprehensions tests due to locals bug
e08377d2d1 Make `comprehensions` into `comprehensions_experimental` for now (ocaml#109)
947cf892b5 List and array comprehensions (ocaml#46)
bd9e051 remove exp_mode from typedtree (ocaml#100)
a9268d2 Fix misplaced attribute warning when using external parser (and some cleanup) (ocaml#101)
2b33f24 Refactor toplevel local escape check (ocaml#104)
ed2aec6 Comment functions exported from TyVarEnv.
87838ba Move new variable creation into TyVarEnv.
a3f60ab Encapsulate functions that work with tyvars
43d83a6 Prevent possibility of forgetting to re-widen
2f3dd34 Encapsulate context when narrowing type env't
d78ff6d Make immediate64 things mode cross (ocaml#97)
aa25ab9 Fix version number (ocaml#94)
d01ffa0 Fix .depend file (ocaml#93)
942f2ab Bootstrap (ocaml#92)
05f7e38 Check Menhir version (ocaml#91)
1569b58 Move the CI jobs from 4.12 to 4.14. (ocaml#90)

git-subtree-dir: ocaml
git-subtree-split: c703f5f7772dd4252405b086be11c15a3c67f2ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.03.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@berke @lpw25 @gasche @UnixJunkie @damiendoligez @maranget