New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard unwind test against old OS X versions #476
Conversation
Guard unwind test against old OS X versions
So this patch breaks our CI infrastructure because the bash-only matching is not supported everywhere. I tried to rewrite it in a more portable way in dd5dc84 , which I pushed in trunk to get some feedback from the CI infrastructure. @btj , would you mind looking at it to confirm that it has the intended semantics? @damiendoligez : apoligies for the hasty merge in the release branch. In the future I'll merge in trunk first and wait for CI report, even for stuff that we want in 4.03 and "obviously doesn't break anything". I can revert the commit if you think it's best, but I hope that the trunk CI will look good and my plan is to merge dd5dc84 directly. |
The patch seems to fix the CI on non-mac machines, so I also pushed it into 4.03 to help people currently testing the branch: 1d9c4a0 . I would still be interested in a confirmation that it also solves the original issue on OSX 10.8 (this CI machine is disabled currently). |
I don't think this does the right thing: the output of
Notice that 1) the version does not appear at the start of the line, and 2) the output consists of 3 lines. |
Yes, except that you do need the |
Of course; I used a literal string for testing, then put back the wrong thing, sorry. The fixed commit is 8dcb687 , and I'm going to sit on it for a dozen of minutes to make sure I haven't forgotten about something, and then push it to 4.03 and trunk. |
This works on my machine (OS X 10.10.1). |
No need to apologize, I've done my fair share of "obviously doesn't break anything" myself... |
Co-authored-by: Thibaut Mattio <thibaut.mattio@gmail.com>
tests/unwind
crashes on OS X 10.8. This fixes that by only running the test if a sufficiently new version ofld
is present on the system.