Warning 50 stdlib #529
Merged
Warning 50 stdlib #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damiendoligez Do you think we could merge this, #528 and #526 in time for the 4.03 release? I would really like to get Merlin's documentation commands working on the standard library for this release. |
|
I think most of it already went into trunk. I guess there should be not conflict (or easy enough to fix), but it's probably a good idea to merge 4.03 into trunk just after accepting this PR. |
|
@damiendoligez ping? |
mshinwell
added a commit
to mshinwell/ocaml
that referenced
this pull request
Jul 1, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: tmattio <tmattio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on warning 50 for the stdlib and otherlibs, and fixes up the resulting warnings.
It is based on #528 so the diff includes those changes as well.
As with #528, I've made the pull request against 4.03 because it fixes the attachment of comments to definitions, which is now used by merlin and so is worth fixing for the release.