New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocamldoc: do not ignore "-open" arguments #613
Conversation
This commit ensures that the modules listed in the "-open" option are opened in the initial environment of ocamldoc.
It seems fine to me, but I'm worried about not having a testsuite for ocamldoc to insert test for this kind of features. I don't think it is the responsibility of this PR to provide one, but we should think about it. |
(Could you squash the three commits?) |
Squashed and merged, thanks! |
For this particular case, it could also make sense to test that all tools interpret the "-open" option |
@gasche well spotted. Will do my best to take this into account and at |
@shindere what about using Mantis tags? If that sounds good to you I (or you) can create an issue to track this particular one with a "testsuite" tag. |
@gasche Why not! If you have the possibility to do it that would be
great, but if you can't I can have a look.
The remark about the fact that "open" should be treated in a consistent
way by all tools seems also very meaningful to me and if that can be
verified by testing, at least to some extent, I'd say it's worth
recording in a safe place.
|
PR#7274: a testsuite for ocamldoc |
It seems there are actually already a few tests, see
testsuite/tests/tool-ocamldoc*
But there is definitely room for many others.
|
Oh, indeed. @Octachron, could you create a test then that check for |
Certainly, I would have a look. |
This pull requests open the module listed as arguments of
-open
in the initial environment of ocamldocto mirror the behavior of
ocaml
,ocamlc
andocamldep
.Without this modification, the "-open" command option has no effect within
ocamldoc
.