Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocamldoc: do not ignore "-open" arguments #613

Closed
wants to merge 3 commits into from

Conversation

Octachron
Copy link
Member

This pull requests open the module listed as arguments of -open in the initial environment of ocamldoc
to mirror the behavior of ocaml, ocamlc and ocamldep.

Without this modification, the "-open" command option has no effect within ocamldoc.

This commit ensures that the modules listed in the "-open" option are
opened in the initial environment of ocamldoc.
@gasche
Copy link
Member

gasche commented Jun 15, 2016

It seems fine to me, but I'm worried about not having a testsuite for ocamldoc to insert test for this kind of features. I don't think it is the responsibility of this PR to provide one, but we should think about it.

@gasche
Copy link
Member

gasche commented Jun 15, 2016

(Could you squash the three commits?)

@gasche
Copy link
Member

gasche commented Jun 15, 2016

Squashed and merged, thanks!

@gasche gasche closed this Jun 15, 2016
@Octachron
Copy link
Member Author

For this particular case, it could also make sense to test that all tools interpret the "-open" option
in a coherent way, since discrepancies between them can make build processes quite painful.

@shindere
Copy link
Contributor

@gasche well spotted. Will do my best to take this into account and at
least record the idea so that it does not get lost.

@gasche
Copy link
Member

gasche commented Jun 15, 2016

@shindere what about using Mantis tags? If that sounds good to you I (or you) can create an issue to track this particular one with a "testsuite" tag.

@shindere
Copy link
Contributor

shindere commented Jun 15, 2016 via email

@gasche
Copy link
Member

gasche commented Jun 15, 2016

PR#7274: a testsuite for ocamldoc
http://caml.inria.fr/mantis/view.php?id=7274

@shindere
Copy link
Contributor

shindere commented Jun 15, 2016 via email

@gasche
Copy link
Member

gasche commented Jun 15, 2016

Oh, indeed. @Octachron, could you create a test then that check for -open support?

@Octachron
Copy link
Member Author

Certainly, I would have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants