Fix #8558 by disabling optimization of local functions, for 4.08 #8560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainfrisch
changed the title
|
I'm lost. Could you please explain what you're doing? |
|
I'm disabling the optimization of local functions, which seems to be the safer fix to me to avoid correctness and performance regression in 4.08 compared to 4.07. |
|
(I was comfortable enough with my proposal in #8559, but not with your simpler fix, which seems too risky to me.) |
|
(I admit that it might be a bit too crazy to be concerned by performance regression on bytecode.) |
|
Oh right, never mind, I'll push the simpler fix after all. If it degrades performance in bytecode, it's not the end of the world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(TODO: adapt the testsuite and the Changes file.)