Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#7370: bump magic number (ocamldep segfault) #877

Merged
merged 1 commit into from Nov 2, 2016

Conversation

damiendoligez
Copy link
Member

The question is: are there any other magic numbers we need to change, and how do we find them?

@damiendoligez damiendoligez added this to the 4.04 milestone Oct 27, 2016
@alainfrisch
Copy link
Contributor

alainfrisch commented Oct 27, 2016

What's the argument against systematically bumping all magic numbers before a release?

@damiendoligez
Copy link
Member Author

You mean a major release, right?

@alainfrisch
Copy link
Contributor

I actually meant any release. I don't see a scenario where users would like to mix .cmi/.cmx/.cmxs files produced by different versions of the compiler. Even if the format doesn't change, the behavior of the compiler does. And even if it didn't, who would take the risk?

@trefis
Copy link
Contributor

trefis commented Oct 28, 2016

It's not about mixing files, it's about the tools processing this file, is it not? Why would you require some tool to be "updated" and built for as many (minor) versions of the compiler if there is no need to?
For instance merlin usually doesn't really need updating between minor releases and you need only build on merlin to work with say ocaml 4.02.2 and 4.02.3.

@alainfrisch
Copy link
Contributor

Even for external tools, I would expect that the installation be usually managed by OPAM, and that the workflow would guarantee that Merlin has been compiled exactly with the same version as the one used for compiling the edited files.

@mshinwell
Copy link
Contributor

I tend to think it's preferable to not bump the version numbers unless required for minor releases. Extra time spent managing deployments that are not using OPAM is a concern here. However I think all of the numbers could reasonably be bumped upon a major release. (Tools such as Merlin would probably need to be changed across such a release in any event.)

@damiendoligez
Copy link
Member Author

damiendoligez commented Nov 2, 2016

We'll probably switch to bumping all the numbers on each major release, but not this time because I'd like to see a bit more discussion (and I'm feeling a bit nervous about breakage).

@damiendoligez damiendoligez merged commit c8629cd into ocaml:4.04 Nov 2, 2016
dra27 pushed a commit to dra27/ocaml that referenced this pull request Dec 10, 2016
dra27 pushed a commit to dra27/ocaml that referenced this pull request Dec 10, 2016
dra27 pushed a commit to dra27/ocaml that referenced this pull request Dec 11, 2016
dra27 pushed a commit to dra27/ocaml that referenced this pull request Dec 11, 2016
dra27 pushed a commit to dra27/ocaml that referenced this pull request Dec 12, 2016
dra27 pushed a commit to dra27/ocaml that referenced this pull request Dec 14, 2016
camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Oct 25, 2022
@damiendoligez damiendoligez deleted the bump-magic-number branch March 8, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants