Fix copy scope bugs #9385

lpw25 · 2020-03-21T15:28:06Z

There were two bugs in the handling of copy_scopes in Subst which lead to #9384 and the bugs from the comments on #9384.

One bug is the classic with_foo currying bug. The other uses separate copy_states for the parameters and body of a type constructor -- losing sharing between the two.

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 · 2020-05-06T20:00:47Z

@trefis I think you know this code, care to review it?

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

trefis

Good catch, thanks!

Sorry for the long delay before reviewing.

hhugo · 2020-06-05T08:07:16Z

@lpw25 this just need a Change entry and fixes to comply with check-typo.
Will this be cherry picked in 4.11 ?

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

Octachron · 2020-06-05T08:16:19Z

This seems like a small bug fix in the alpha period. It should be fine to cherry-pick to 4.11 . Except if @trefis or @lpw25 have any objections.

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 · 2020-06-05T09:47:24Z

Rebased, fixed check-typo issue, Changes entry added. This should indeed go in 4.11.

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 · 2020-06-14T07:31:42Z

Tests were failing after the rebase, I've updated them now.

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

hhugo · 2020-06-24T16:05:24Z

Is this ready to be merged ?

Fix copy scope bugs (cherry picked from commit 1f9be49)

lpw25 · 2020-06-25T10:10:39Z

Cherry picked to 4.11 as a091c89

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 mentioned this pull request Mar 21, 2020

Structure fails to ascribe to signature with signature-local binding #9384

Closed

stedolan added a commit to janestreet/ocaml that referenced this pull request Apr 1, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

ec508e1

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

hhugo pushed a commit to janestreet/ocaml that referenced this pull request May 25, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

eb7d6ee

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

hhugo pushed a commit to janestreet/ocaml that referenced this pull request May 29, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

683b80a

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

hhugo pushed a commit to janestreet/ocaml that referenced this pull request Jun 2, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

8a63fd4

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

hhugo pushed a commit to janestreet/ocaml that referenced this pull request Jun 3, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

e281c18

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

trefis approved these changes Jun 4, 2020

View reviewed changes

hhugo pushed a commit to janestreet/ocaml that referenced this pull request Jun 5, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

573449e

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

hhugo pushed a commit to janestreet/ocaml that referenced this pull request Jun 5, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

3a005b8

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 force-pushed the fix-copy-scope-bugs branch from 288bb81 to 8fbffb8 Compare June 5, 2020 09:46

hhugo pushed a commit to janestreet/ocaml that referenced this pull request Jun 10, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

9b4885a

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 added 3 commits June 14, 2020 08:25

Add regression tests

0806049

Fix incorrect copy_scopes in Subst

8190209

Add Changes entry

a15b97b

lpw25 force-pushed the fix-copy-scope-bugs branch from 8fbffb8 to a15b97b Compare June 14, 2020 07:30

hhugo pushed a commit to janestreet/ocaml that referenced this pull request Jun 24, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

160fa5a

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 merged commit 1f9be49 into ocaml:trunk Jun 25, 2020

lpw25 added a commit that referenced this pull request Jun 25, 2020

Merge pull request #9385 from lpw25/fix-copy-scope-bugs

a091c89

Fix copy scope bugs (cherry picked from commit 1f9be49)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 16, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

c4c6445

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 20, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

f4f5b98

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 20, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

b6f5c9d

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 21, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

6f0b1d7

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 21, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

b133d5c

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 30, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

ff880a8

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Jul 30, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

8f39a54

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 3, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

37d9c16

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 4, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

8053fbc

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 5, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

af4ac93

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 7, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

2fcf739

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 10, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

f60e698

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 10, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

86abd30

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 17, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

1ab3cc5

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 18, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

bb4680c

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 19, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

341d46d

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 20, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

a7a0254

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Aug 28, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

655c431

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Sep 2, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

19171ef

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Sep 2, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

bca21b5

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Sep 2, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

921efa8

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

lpw25 mentioned this pull request Sep 7, 2020

The attack of the binding operators: introduce (let@) in the compiler codebase #9887

Open

mshinwell pushed a commit to mshinwell/ocaml that referenced this pull request Sep 7, 2020

ocaml#9385 from lpw25/fix-copy-scope-bugs

46d63b9

Fix incorrect copy_scopes in Subst (cherry picked from commit 288bb81) (cherry picked from commit 2e08e99)

gadmm mentioned this pull request Sep 3, 2021

Add {In,Out}_channel.with_open_{bin,text,gen} and In_channel.input_all #10596

Merged

gasche mentioned this pull request Sep 3, 2021

a [@warn-partial-application] attribute for function arguments where a ground type is expected #10604

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix copy scope bugs #9385

Fix copy scope bugs #9385

lpw25 commented Mar 21, 2020

lpw25 commented May 6, 2020

trefis left a comment

hhugo commented Jun 5, 2020

Octachron commented Jun 5, 2020

lpw25 commented Jun 5, 2020

lpw25 commented Jun 14, 2020

hhugo commented Jun 24, 2020

lpw25 commented Jun 25, 2020

Fix copy scope bugs #9385

Fix copy scope bugs #9385

Conversation

lpw25 commented Mar 21, 2020

lpw25 commented May 6, 2020

trefis left a comment

Choose a reason for hiding this comment

hhugo commented Jun 5, 2020

Octachron commented Jun 5, 2020

lpw25 commented Jun 5, 2020

lpw25 commented Jun 14, 2020

hhugo commented Jun 24, 2020

lpw25 commented Jun 25, 2020