Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of dead code that was introduced for an hypothetical JIT. #9710

Merged
merged 2 commits into from Jul 5, 2020

Conversation

jhjourdan
Copy link
Contributor

@jhjourdan jhjourdan commented Jun 25, 2020

This was introduced in 2004 as part of a project to develop a JIT for OCaml's bytecode but it seems not to be used for a long time.

Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up on this topic. The code removal is obviously correct. I am in favor of removing the code, but will leave a couple of days for other opinions to be heard.

@jhjourdan
Copy link
Contributor Author

BTW, does this deserves a Changes entry ?

@gasche
Copy link
Member

gasche commented Jun 25, 2020

Yes. Sounds useful, if someone asks about those features in a distant future, to be able to tell quickly when they were removed.

@jhjourdan jhjourdan changed the title Get rid of dead code that was introduced for an hypothetical JIT but never used. Get rid of dead code that was introduced for an hypothetical JIT. Jun 26, 2020
@jhjourdan
Copy link
Contributor Author

Cc @bstarynk, since he was the original author of the code.

@xavierleroy
Copy link
Contributor

No other opinion was heard, so I'll merge.

@xavierleroy xavierleroy merged commit 0616261 into ocaml:trunk Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants