Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ephemeron compatible with infix pointers. #9742

Merged
merged 2 commits into from Jul 27, 2020

Conversation

jhjourdan
Copy link
Contributor

This fixes #9485 and #7810.

Cc @bobot, @damiendoligez.

@jhjourdan
Copy link
Contributor Author

I am not completely sure I did not miss any patch, perhaps, @bobot, you could check a bit more.

@jhjourdan
Copy link
Contributor Author

Since this is a bugfix, this could be back ported to 4.11. That said, given that this bug exists for a long time for weak pointers and nobody was really annoyed, this may not be necessary.

@xavierleroy
Copy link
Contributor

@bobot, @damiendoligez : this is a bug fix for an area of the run-time system that you are responsible for. Please review.

Copy link
Contributor

@bobot bobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the heads up. I think one case remains to be done. However in #9424 I will need to add this infix handling in many places.

runtime/minor_gc.c Show resolved Hide resolved
runtime/caml/weak.h Show resolved Hide resolved
@xavierleroy
Copy link
Contributor

@bobot are you happy with the revised PR? @damiendoligez would you care to comment?

Copy link
Contributor

@bobot bobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@xavierleroy
Copy link
Contributor

Thank you gentlemen, I'll merge now. It's too late for a backport to 4.11, this will wait until 4.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in Weak.get_copy with Infix_tag
3 participants