Driver #1121
Merged
Driver #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
reviewed
May 14, 2024
src/driver/library.ml
Outdated
There was a problem hiding this comment.
I guess this file is meant to be removed!
src/odoc/classify.ml
Outdated
Comment on lines
42
to
53
| { | ||
| lib with | ||
| modules = StringSet.add cu.cu_name lib.modules; | ||
| intf_deps = | ||
| List.fold_left | ||
| (fun deps (cu, _) -> StringSet.add cu deps) | ||
| lib.intf_deps cu.cu_imports; | ||
| impl_deps = | ||
| List.fold_left | ||
| (fun deps id -> StringSet.add (Ident.name id) deps) | ||
| lib.impl_deps cu.cu_required_globals; | ||
| } |
There was a problem hiding this comment.
There is some compatibility issues with OCaml 5.2 here...
The 5.2 version would be:
Suggested change
| { | |
| lib with | |
| modules = StringSet.add cu.cu_name lib.modules; | |
| intf_deps = | |
| List.fold_left | |
| (fun deps (cu, _) -> StringSet.add cu deps) | |
| lib.intf_deps cu.cu_imports; | |
| impl_deps = | |
| List.fold_left | |
| (fun deps id -> StringSet.add (Ident.name id) deps) | |
| lib.impl_deps cu.cu_required_globals; | |
| } | |
| { | |
| lib with | |
| modules = | |
| StringSet.add (match cu.cu_name with Compunit s -> s) lib.modules; | |
| intf_deps = | |
| List.fold_left | |
| (fun deps (cu, _) -> StringSet.add cu deps) | |
| lib.intf_deps cu.cu_imports; | |
| impl_deps = | |
| List.fold_left | |
| (fun deps id -> StringSet.add id deps) | |
| lib.impl_deps | |
| (List.map (fun (Compunit s) -> s) cu.cu_required_compunits); | |
| } |
This is essentially identical to the code extracted from driver.mld
Essentially renamed compile-src command. These need a bit of polish before we release, but this is enough for the new driver to be testing the interface.
|
OK, green tick, in it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new driver for testing the odoc 3.0 implementation. It's based on a combination of our current mld driver and bits of ocaml-doc/voodoo. Also included are some draft changes to the CLI. These will need a bit of polish!
Requires eio for parallelism and therefore OCaml >= 5.1, and should therefore be in a different opam package.
I'm making this PR very early as we'll be collaborating on the driver as we make the odoc 3 implementation changes.