Fix record fields and constructors indentation #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The indentation fix is great 👍 . I'll merge as soon as you drop the linkification change (as we discussed in #506 ). |
|
Also, as a small aside: if we decide to remove pieces of markup, I prefer to actually remove them, instead of just turning them invisible. ;) |
Signed-off-by: lubegasimon <lubegasimon73@gmail.com>
lubegasimon
force-pushed
the
fix-record-fields-and-constructor-concerns
branch
from
94d975f
to
b1c4a8d
Compare
You're right, for performance reasons. |
lubegasimon
changed the title
Actually, no: for software engineering reason: code that is used to produce unneeded stuff is dead, and dead code is technical debt, which leads to unmaintainable messy software. |
Drup
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #505.