HTML backend: refine specification rendering #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While doing this PR I realized the rendering by the default stylesheet of variants with a doc string is not very nice, I just want to stress that this is not a side effect of this PR. I don't think it's worth fixing before #614 is. |
Drup
approved these changes
Mar 9, 2021
dbuenzli
force-pushed
the
documentedsrc-kind
branch
from
ae78979
to
db135b3
Compare
We simply use the `attr` pattern already present in the IR model. This also slightly tweaks some of the "kinds": * `extension` becomes `type extension` * `type-subst` becomes `type subst` * `external` becomes `value external` * `instance-variable` becomes `value instance-variable` Fixes part of ocaml#601.
dbuenzli
force-pushed
the
documentedsrc-kind
branch
from
db135b3
to
b716452
Compare
This has been removed.
I suggest we do that in a separate PR once #630 has been resolved. The PR has been rebased |
|
Thanks! |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #612, the relevant commits start at e7d6fd3
It does the following:
->so that browsers can be instructednot to break it.
type#601 adds several kinds forItem. We reuse theClass.ttype usually namedattr(sic). A few items get reclassified, mostly in a backward compatible way. See the commit message for details..docto.def-doc.odoc.csswith the changes.Tweakodoc.cssfor better c&p behaviour (closes Record field and variant case rendering breaks cut and paste #296).