Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf-postgres depext needs to be updated for homebrew #23912

Closed
haochenx opened this issue Jun 12, 2023 · 4 comments · Fixed by #24105
Closed

conf-postgres depext needs to be updated for homebrew #23912

haochenx opened this issue Jun 12, 2023 · 4 comments · Fixed by #24105

Comments

@haochenx
Copy link
Collaborator

Currently the package conf-postgres is specifying postgresql as the homebrew package to install on macOS (when using homebrew)

["postgresql"] {os = "macos" & os-distribution = "homebrew"}

But recently with homebrew, one has to explicitly specify the major version of postgres to install, e.g. brew install postgresql@14 or brew install postgresql@15 and brew install postgresql will fail.

@haochenx
Copy link
Collaborator Author

@mmottl do you have an opinion about how we should deal with this?

@mmottl
Copy link
Contributor

mmottl commented Jul 14, 2023

I believe specifying a particular version may be the only reasonable choice. This is the way this problem is handled for other platforms. You may want to settle on a really stable and popular version for that.

@haochenx
Copy link
Collaborator Author

haochenx commented Jul 14, 2023

All officially released major versions of Postgres are reasonably stable and have long support periods (e.g., the current newest stable release is Postgres 15, which is released last year and will be supported until 2027).

Also, it seems that the newest Postgres 15 enjoys supports back to Big Sur on both Apple Silicon and Intel models, I think it's reasonable to default to the give the user the newest version (now Postgres 15) by default.

@haochenx
Copy link
Collaborator Author

I have opened PR #24105 to address this.

kit-ty-kate added a commit that referenced this issue Aug 9, 2023
conf-postgresql - update depexts package name for macos + homebrew (#23912)
nberth pushed a commit to nberth/opam-repository that referenced this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants