4 packages from gitlab.com/nomadic-labs/data-encoding/-/archive/v1.0.1/data-encoding-v1.0.1.tar.gz #24678
Conversation
|
Turns out there's a missing constraint on zarith. I'm adding this. |
|
janestreet/zarith_stubs_js#10 ← this is meant to fix the underlying issue. |
|
Still tests failing here... |
|
After #24755 is merged this here MR should be updated with new constraints. |
…1/data-encoding-v1.0.1.tar.gz
raphael-proust
force-pushed
the
opam-publish-data-encoding-json-data-encoding-json-data-encoding-browser-json-data-encoding-bson.1.0.1
branch
from
df9c11f
to
1d78feb
Compare
|
Updated with zarith stubs constraints |
|
CI errors are:
I don't care too much about the s390x/5.1 issue because it is quite a specific combination. |
Should we make it unavailable there? It may be something to do with little or big endianness. |
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
|
I've added the availability field. I don't think it's an endianness issue because it works on s390x-ocaml.4.14. So it's probably a combination of multiple factors, endianness being only one of them? |
|
Possibly ocaml/ocaml#12919 for on s390x |
|
What is the status? Can we merge this? |
|
@mseri I guess technically the package is fine but the s390x+ocaml.5.1 combination is broken. I'm ok merging with the current availability field. The main issue is that when a new version of ocaml is released with the issue fixed we should then fix the Still, I think we can merge. |
|
Please send an update to the availability field once a fixed ocaml is released |
This pull-request concerns:
-
data-encoding.1.0.1: Library of JSON and binary encoding combinators-
json-data-encoding.1.0.1: Type-safe encoding to and decoding from JSON-
json-data-encoding-browser.1.0.1: Type-safe encoding to and decoding from JSON (browser support)-
json-data-encoding-bson.1.0.1: Type-safe encoding to and decoding from JSON (bson support)🐫 Pull-request generated by opam-publish v2.1.0