-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark conflict in zarith_js_stubs #24681
Mark conflict in zarith_js_stubs #24681
Conversation
@@ -14,7 +14,7 @@ depends: [ | |||
"dune" {>= "2.0.0"} | |||
] | |||
# The conflict is a run-time failure when versions do not match: | |||
conflicts: "zarith" {< "1.12"} | |||
conflicts: [ "zarith" {< "1.12" | >= "1.13" } ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts: [ "zarith" {< "1.12" | >= "1.13" } ] | |
conflicts: [ "zarith" {< "1.12" | >= "1.13" } ] |
Is there any compatible zarith version in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess zarith.1.12 is the only version compatible with that release of zarith-stubs-js. But I'm a bit tired so I don't really trust myself on having gotten the comparison and operators right.
Btw, the previous constraint is from #21056
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was sleeping, I saw equal signs on both sides :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts: [ "zarith" {< "1.12" | >= "1.13" } ] | |
conflicts: [ "zarith" {!= "1.12" } ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed essentially this but added a comment too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original < and >= was a better constraint, since it allows for any variants of zarith.1.12 to also match (e.g. zarith.1.12+dune
, that sort of thing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to <
and >=
Well it seems there are more conflicts because there's a |
See also #24755 |
1d67855
to
ecd6f3b
Compare
So there are still CI errors. Most of which are irrelevant (they are transient errors, broken tezos packages, or some such) and a few of them are relevant (the data-encoding.1.0.0 error). However,
|
Thanks a lot |
* Mark conflict in zarith_js_stubs * More conflicts in more versions * Add comments explaining conflicts * revert to < and >= constraints see ocaml#24681 (comment)
Calling the extract function makes a runtime failure:
[failure] ml_z_extract_small not implemented
See also janestreet/zarith_stubs_js#10
Note that the error is only triggered when calling the missing function, so it's not necessarily a strict conflict, but there is precedent in the other zarith version for similar issues.