Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: constraint to cstruct <3.1.1 due to ocplib-endian dep #10381

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

avsm
Copy link
Member

@avsm avsm commented Oct 2, 2017

This is because cstruct 3.2.0 will remove ocplib-endian use
(mirage/ocaml-cstruct#177), which in turn causes a transitive
build failure on older versions of git (mirage/ocaml-git#233)

This is because cstruct 3.2.0 will remove ocplib-endian use
(mirage/ocaml-cstruct#177), which in turn causes a transitive
build failure on older versions of git (mirage/ocaml-git#233)
@camelus
Copy link
Contributor

camelus commented Oct 2, 2017

✅ All lint checks passed 29f69b7
  • These packages passed lint tests: git.1.6.0, git.1.6.1, git.1.6.2, git.1.7.0, git.1.7.1, git.1.7.2, git.1.8.0, git.1.9.0, git.1.9.1, git.1.9.2, git.1.9.3

✅ Installability check (7503 → 7503)

@seliopou
Copy link
Contributor

Looks like all the build failures were caused by the source code for findlib being unavailable. I restarted the datakit jobs but Travis needs a kick as well.

@dbuenzli
Copy link
Collaborator

Travis kicked !

@avsm avsm merged commit 44017c2 into ocaml:master Nov 7, 2017
hannesm added a commit to hannesm/opam-repository that referenced this pull request Nov 17, 2017
yomimono added a commit that referenced this pull request Nov 19, 2017
continue #10381: conflict git with cstruct > 3.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants